feat: troppa roba davvero

backend/tests/services/test_mitmproxy_manager.py

@@ -1,9 +1,11 @@
 import asyncio
 from pathlib import Path
 
-from models.proxy import ProxyDocument
-from models.service import ServiceEndpointDocument
-from services.mitmproxy.manager import MitmdumpManager
+import pytest
+
+from app.models.proxy import ProxyDocument
+from app.models.service import ServiceEndpointDocument
+from app.services.mitmproxy.manager import MitmdumpError, MitmdumpManager
 
 
 def make_proxy(**updates):
@@ -65,6 +67,20 @@ def test_regular_mode_uses_proxy_port_as_listen_port():
     assert command[-2:] == ["--listen-port", "8080"]
 
 
+def test_start_rejects_reserved_backend_port():
+    manager = MitmdumpManager()
+    proxy = make_proxy(proxy_port=3671)
+
+    async def run():
+        await manager.start(proxy)
+
+    with pytest.raises(
+        MitmdumpError,
+        match="Proxy port 3671 is reserved for the backend API",
+    ):
+        asyncio.run(run())
+
+
 def test_running_document_without_pid_is_treated_as_stopped():
     manager = MitmdumpManager()
     proxy = make_proxy(status="running", pid=None)
@@ -167,3 +183,99 @@ def test_reconcile_restores_upstream_when_process_is_gone():
         "service.upstream_port": None,
         "last_error": None,
     }
+
+
+def test_cleanup_runtime_artifacts_removes_generated_files(tmp_path: Path):
+    manager = MitmdumpManager(work_dir=str(tmp_path / "theplug"))
+    proxy = make_proxy(
+        script_path=str(manager.script_path_for(make_proxy())),
+        config_path=str(manager.config_path_for(make_proxy())),
+        log_path=str(manager.log_path_for(make_proxy())),
+    )
+
+    script_path = Path(proxy.script_path)
+    config_path = Path(proxy.config_path)
+    log_path = Path(proxy.log_path)
+    script_path.parent.mkdir(parents=True, exist_ok=True)
+    config_path.parent.mkdir(parents=True, exist_ok=True)
+    log_path.parent.mkdir(parents=True, exist_ok=True)
+    script_path.write_text("print('hello')", encoding="utf-8")
+    config_path.write_text("block_global: false\n", encoding="utf-8")
+    log_path.write_text("old log\n", encoding="utf-8")
+
+    manager.cleanup_runtime_artifacts(proxy)
+
+    assert script_path.exists() is False
+    assert log_path.exists() is False
+    assert config_path.exists() is False
+    assert manager.conf_dir_for(proxy).exists() is False
+
+
+def test_prepare_upstream_retries_until_port_remap_succeeds(monkeypatch):
+    manager = MitmdumpManager()
+    proxy = make_proxy(
+        mode="reverse",
+        service=ServiceEndpointDocument(
+            port=9000,
+            name="echo",
+            folder="/tmp/playground",
+        ),
+    )
+    attempted_ports: list[int] = []
+    candidate_ports = iter([54001, 54002, 54003])
+
+    async def fake_change_port(
+        _service_name,
+        _folder,
+        _port_from,
+        port_to,
+        **_kwargs,
+    ):
+        attempted_ports.append(port_to)
+        return port_to == 54003
+
+    monkeypatch.setattr(
+        "app.services.mitmproxy.manager.get_random_port",
+        lambda: next(candidate_ports),
+    )
+    monkeypatch.setattr(
+        "app.services.mitmproxy.manager.change_port",
+        fake_change_port,
+    )
+
+    upstream_port = asyncio.run(manager.prepare_upstream(proxy))
+
+    assert upstream_port == 54003
+    assert attempted_ports == [54001, 54002, 54003]
+
+
+def test_prepare_upstream_fails_after_retry_budget(monkeypatch):
+    manager = MitmdumpManager()
+    manager.upstream_port_attempts = 3
+    proxy = make_proxy(
+        mode="reverse",
+        service=ServiceEndpointDocument(
+            port=9000,
+            name="echo",
+            folder="/tmp/playground",
+        ),
+    )
+    candidate_ports = iter([54001, 54002, 54003])
+
+    async def fake_change_port(*_args, **_kwargs):
+        return False
+
+    monkeypatch.setattr(
+        "app.services.mitmproxy.manager.get_random_port",
+        lambda: next(candidate_ports),
+    )
+    monkeypatch.setattr(
+        "app.services.mitmproxy.manager.change_port",
+        fake_change_port,
+    )
+
+    with pytest.raises(
+        MitmdumpError,
+        match="Unable to move Docker service port after retries",
+    ):
+        asyncio.run(manager.prepare_upstream(proxy))