feat: troppa roba davvero

backend/app/integrations/docker/editor.py

@@ -1,14 +1,26 @@
+import asyncio
 from pathlib import Path
 
 import yaml
-from integrations.docker.compose import find_docker_compose, run_docker_command
-from integrations.docker.ports import _get_port_index, _replace_port_in_mapping
+
+from app.integrations.docker.compose import (
+    ComposeDocument,
+    find_docker_compose,
+    run_docker_command,
+)
+from app.integrations.docker.ports import _get_port_index, _replace_port_in_mapping
 
 
-def _backup_path_for(compose_path: Path) -> Path:
-    if compose_path.suffix in {".yml", ".yaml"}:
-        return compose_path.with_name(f"{compose_path.stem}.bak{compose_path.suffix}")
-    return compose_path.with_name(f"{compose_path.name}.bak")
+def _render_compose(document: ComposeDocument) -> str:
+    return yaml.dump(document, default_flow_style=False, sort_keys=False)
+
+
+def _write_compose(path: Path, content: str) -> None:
+    path.write_text(content, encoding="utf-8")
+
+
+def _read_compose_text(path: Path) -> str:
+    return path.read_text(encoding="utf-8")
 
 
 async def change_port(
@@ -25,7 +37,7 @@ async def change_port(
 
     docker_compose, compose_path = compose_data
     compose_services = docker_compose.get("services") or {}
-    if not compose_services:
+    if not isinstance(compose_services, dict) or not compose_services:
         return False
 
     service_config = compose_services.get(service_name)
@@ -48,21 +60,26 @@ async def change_port(
         rewrite_host=rewrite_host,
     )
 
-    backup_path = _backup_path_for(compose_path)
-    original_text = compose_path.read_text()
+    original_text = await asyncio.to_thread(_read_compose_text, compose_path)
+    updated_text = _render_compose(docker_compose)
 
-    backup_path.write_text(compose_path.read_text())
-    compose_path.write_text(
-        yaml.dump(docker_compose, default_flow_style=False, sort_keys=False)
-    )
-
-    result = await run_docker_command(
-        compose_path,
-        ["up", "-d", service_name],
-    )
+    try:
+        await asyncio.to_thread(_write_compose, compose_path, updated_text)
+        result = await run_docker_command(
+            compose_path,
+            ["up", "-d", service_name],
+        )
+    except Exception:
+        try:
+            await asyncio.to_thread(_write_compose, compose_path, original_text)
+        except OSError as restore_error:
+            raise RuntimeError(
+                f"Failed to restore original compose file: {compose_path}"
+            ) from restore_error
+        return False
 
     if result is None or result.get("status") != "success":
-        compose_path.write_text(original_text)
+        await asyncio.to_thread(_write_compose, compose_path, original_text)
         return False
 
     return True