feat: troppa roba davvero

backend/app/integrations/docker/__init__.py

@@ -1,10 +1,10 @@
-from integrations.docker.compose import (
+from app.integrations.docker.compose import (
     find_docker_compose,
     get_all_services_in_dir,
     get_services,
 )
-from integrations.docker.editor import change_port
-from integrations.docker.models import DockerContainer
+from app.integrations.docker.editor import change_port
+from app.integrations.docker.models import DockerContainer
 
 __all__ = [
     "DockerContainer",

backend/app/integrations/docker/compose.py

@@ -2,8 +2,9 @@ import asyncio
 from pathlib import Path
 
 import yaml
-from integrations.docker.models import DockerContainer
-from integrations.docker.ports import _get_service_binding
+
+from app.integrations.docker.models import DockerContainer, DockerPortBinding
+from app.integrations.docker.ports import _get_service_binding
 
 COMPOSE_NAMES = (
     "compose.yml",
@@ -12,24 +13,43 @@ COMPOSE_NAMES = (
     "docker-compose.yaml",
 )
 
+type ComposeDocument = dict[str, object]
+
 
 def _get_visible_folders(directory: Path) -> list[Path]:
-    return [
-        p
-        for p in Path(directory).iterdir()
-        if p.is_dir() and not p.name.startswith(".")
-    ]
+    try:
+        entries = list(Path(directory).iterdir())
+    except OSError:
+        return []
+
+    folders: list[Path] = []
+    for entry in entries:
+        if entry.name.startswith("."):
+            continue
+        try:
+            if entry.is_dir():
+                folders.append(entry)
+        except OSError:
+            continue
+
+    return folders
 
 
-def find_docker_compose(path: Path) -> tuple[dict, Path] | None:
-    if not path or not path.is_dir():
+def find_docker_compose(path: Path) -> tuple[ComposeDocument, Path] | None:
+    try:
+        if not path or not path.is_dir():
+            return None
+    except OSError:
         return None
 
     for name in COMPOSE_NAMES:
         file = path / name
-        if file.is_file():
-            content = yaml.safe_load(file.read_text()) or {}
-            return content, file
+        try:
+            if file.is_file():
+                content = yaml.safe_load(file.read_text()) or {}
+                return content, file
+        except OSError:
+            continue
 
     return None
 
@@ -42,7 +62,7 @@ def get_services(folder: Path) -> list[DockerContainer] | None:
 
     docker_compose, _ = compose_data
     compose_services = docker_compose.get("services") or {}
-    if not compose_services:
+    if not isinstance(compose_services, dict) or not compose_services:
         return None
 
     for service_name, config in compose_services.items():
@@ -50,7 +70,7 @@ def get_services(folder: Path) -> list[DockerContainer] | None:
         if not isinstance(mappings, list) or not mappings:
             continue
 
-        bindings = [
+        bindings: list[DockerPortBinding] = [
             {"published": published, "host": host}
             for published, host in (
                 _get_service_binding(mapping) for mapping in mappings
@@ -76,7 +96,10 @@ def get_all_services_in_dir(
     directory: str | Path,
 ) -> list[DockerContainer]:
     path = Path(directory)
-    if not path.is_dir():
+    try:
+        if not path.is_dir():
+            return []
+    except OSError:
         return []
 
     services: list[DockerContainer] = []
@@ -88,7 +111,10 @@ def get_all_services_in_dir(
     return services
 
 
-async def run_docker_command(file: Path, command: list[str]) -> dict | None:
+async def run_docker_command(
+    file: Path,
+    command: list[str],
+) -> dict[str, str] | None:
     if not command:
         return None
 

backend/app/integrations/docker/discovery.py

@@ -1,6 +1,6 @@
 from pathlib import Path
 
-from core.config import settings
+from app.core.config import settings
 
 
 def service_scan_root() -> Path:

backend/app/integrations/docker/editor.py

@@ -1,14 +1,26 @@
+import asyncio
 from pathlib import Path
 
 import yaml
-from integrations.docker.compose import find_docker_compose, run_docker_command
-from integrations.docker.ports import _get_port_index, _replace_port_in_mapping
+
+from app.integrations.docker.compose import (
+    ComposeDocument,
+    find_docker_compose,
+    run_docker_command,
+)
+from app.integrations.docker.ports import _get_port_index, _replace_port_in_mapping
 
 
-def _backup_path_for(compose_path: Path) -> Path:
-    if compose_path.suffix in {".yml", ".yaml"}:
-        return compose_path.with_name(f"{compose_path.stem}.bak{compose_path.suffix}")
-    return compose_path.with_name(f"{compose_path.name}.bak")
+def _render_compose(document: ComposeDocument) -> str:
+    return yaml.dump(document, default_flow_style=False, sort_keys=False)
+
+
+def _write_compose(path: Path, content: str) -> None:
+    path.write_text(content, encoding="utf-8")
+
+
+def _read_compose_text(path: Path) -> str:
+    return path.read_text(encoding="utf-8")
 
 
 async def change_port(
@@ -25,7 +37,7 @@ async def change_port(
 
     docker_compose, compose_path = compose_data
     compose_services = docker_compose.get("services") or {}
-    if not compose_services:
+    if not isinstance(compose_services, dict) or not compose_services:
         return False
 
     service_config = compose_services.get(service_name)
@@ -48,21 +60,26 @@ async def change_port(
         rewrite_host=rewrite_host,
     )
 
-    backup_path = _backup_path_for(compose_path)
-    original_text = compose_path.read_text()
+    original_text = await asyncio.to_thread(_read_compose_text, compose_path)
+    updated_text = _render_compose(docker_compose)
 
-    backup_path.write_text(compose_path.read_text())
-    compose_path.write_text(
-        yaml.dump(docker_compose, default_flow_style=False, sort_keys=False)
-    )
-
-    result = await run_docker_command(
-        compose_path,
-        ["up", "-d", service_name],
-    )
+    try:
+        await asyncio.to_thread(_write_compose, compose_path, updated_text)
+        result = await run_docker_command(
+            compose_path,
+            ["up", "-d", service_name],
+        )
+    except Exception:
+        try:
+            await asyncio.to_thread(_write_compose, compose_path, original_text)
+        except OSError as restore_error:
+            raise RuntimeError(
+                f"Failed to restore original compose file: {compose_path}"
+            ) from restore_error
+        return False
 
     if result is None or result.get("status") != "success":
-        compose_path.write_text(original_text)
+        await asyncio.to_thread(_write_compose, compose_path, original_text)
         return False
 
     return True

backend/app/integrations/docker/ports.py

@@ -24,10 +24,10 @@ def _get_service_binding(
         published = mapping.get("published")
         if published is None:
             return None, None
+        if not isinstance(published, (str, int)):
+            return None, None
         try:
             port = int(published)
-        except TypeError:
-            return None, None
         except ValueError:
             return None, None
         host = mapping.get("host_ip")