refractor(auth): removed password from everywhere

controllers/UserController.cc

@@ -32,19 +32,6 @@ std::optional<visione::auth::UserContext> requireUser(
     }
     return user;
 }
-
-bool blockPasswordChangeRequired(
-    const visione::auth::UserContext &user,
-    std::function<void(const HttpResponsePtr &)> &callback)
-{
-    if (!visione::auth::mustChangePassword(user))
-    {
-        return false;
-    }
-    callback(visione::http::error("password_change_required",
-                                  drogon::k403Forbidden));
-    return true;
-}
 }  // namespace
 
 void UserController::listNotifications(
@@ -52,7 +39,7 @@ void UserController::listNotifications(
     std::function<void(const HttpResponsePtr &)> &&callback)
 {
     auto user = requireUser(req, callback);
-    if (!user || blockPasswordChangeRequired(*user, callback))
+    if (!user)
     {
         return;
     }
@@ -68,7 +55,7 @@ void UserController::markNotificationRead(
     long long notificationId)
 {
     auto user = requireUser(req, callback);
-    if (!user || blockPasswordChangeRequired(*user, callback))
+    if (!user)
     {
         return;
     }
@@ -84,7 +71,7 @@ void UserController::markAllNotificationsRead(
     std::function<void(const HttpResponsePtr &)> &&callback)
 {
     auto user = requireUser(req, callback);
-    if (!user || blockPasswordChangeRequired(*user, callback))
+    if (!user)
     {
         return;
     }
@@ -97,7 +84,7 @@ void UserController::rewards(
     std::function<void(const HttpResponsePtr &)> &&callback)
 {
     auto user = requireUser(req, callback);
-    if (!user || blockPasswordChangeRequired(*user, callback))
+    if (!user)
     {
         return;
     }