refractor(auth): removed password from everywhere

controllers/AdminController.cc

@@ -33,19 +33,6 @@ std::optional<visione::auth::UserContext> requireUser(
     return user;
 }
 
-bool blockPasswordChangeRequired(
-    const visione::auth::UserContext &user,
-    std::function<void(const HttpResponsePtr &)> &callback)
-{
-    if (!visione::auth::mustChangePassword(user))
-    {
-        return false;
-    }
-    callback(visione::http::error("password_change_required",
-                                  drogon::k403Forbidden));
-    return true;
-}
-
 void sendAdmin(Json::Value body,
                std::function<void(const HttpResponsePtr &)> &&callback)
 {
@@ -86,7 +73,7 @@ void AdminController::createCategory(
     std::function<void(const HttpResponsePtr &)> &&callback)
 {
     auto user = requireUser(req, callback);
-    if (!user || blockPasswordChangeRequired(*user, callback))
+    if (!user)
     {
         return;
     }
@@ -100,7 +87,7 @@ void AdminController::createArea(
     std::function<void(const HttpResponsePtr &)> &&callback)
 {
     auto user = requireUser(req, callback);
-    if (!user || blockPasswordChangeRequired(*user, callback))
+    if (!user)
     {
         return;
     }
@@ -114,7 +101,7 @@ void AdminController::createTeam(
     std::function<void(const HttpResponsePtr &)> &&callback)
 {
     auto user = requireUser(req, callback);
-    if (!user || blockPasswordChangeRequired(*user, callback))
+    if (!user)
     {
         return;
     }
@@ -129,7 +116,7 @@ void AdminController::updateCategory(
     long long categoryId)
 {
     auto user = requireUser(req, callback);
-    if (!user || blockPasswordChangeRequired(*user, callback))
+    if (!user)
     {
         return;
     }
@@ -144,7 +131,7 @@ void AdminController::deleteCategory(
     long long categoryId)
 {
     auto user = requireUser(req, callback);
-    if (!user || blockPasswordChangeRequired(*user, callback))
+    if (!user)
     {
         return;
     }
@@ -158,7 +145,7 @@ void AdminController::updateArea(
     long long areaId)
 {
     auto user = requireUser(req, callback);
-    if (!user || blockPasswordChangeRequired(*user, callback))
+    if (!user)
     {
         return;
     }
@@ -173,7 +160,7 @@ void AdminController::deleteArea(
     long long areaId)
 {
     auto user = requireUser(req, callback);
-    if (!user || blockPasswordChangeRequired(*user, callback))
+    if (!user)
     {
         return;
     }
@@ -187,7 +174,7 @@ void AdminController::updateTeam(
     long long teamId)
 {
     auto user = requireUser(req, callback);
-    if (!user || blockPasswordChangeRequired(*user, callback))
+    if (!user)
     {
         return;
     }
@@ -202,7 +189,7 @@ void AdminController::deleteTeam(
     long long teamId)
 {
     auto user = requireUser(req, callback);
-    if (!user || blockPasswordChangeRequired(*user, callback))
+    if (!user)
     {
         return;
     }
@@ -215,7 +202,7 @@ void AdminController::overviewStats(
     std::function<void(const HttpResponsePtr &)> &&callback)
 {
     auto user = requireUser(req, callback);
-    if (!user || blockPasswordChangeRequired(*user, callback))
+    if (!user)
     {
         return;
     }
@@ -228,7 +215,7 @@ void AdminController::listModeration(
     std::function<void(const HttpResponsePtr &)> &&callback)
 {
     auto user = requireUser(req, callback);
-    if (!user || blockPasswordChangeRequired(*user, callback))
+    if (!user)
     {
         return;
     }
@@ -246,7 +233,7 @@ void AdminController::updateModeration(
     long long flagId)
 {
     auto user = requireUser(req, callback);
-    if (!user || blockPasswordChangeRequired(*user, callback))
+    if (!user)
     {
         return;
     }
@@ -260,7 +247,7 @@ void AdminController::listUsers(
     std::function<void(const HttpResponsePtr &)> &&callback)
 {
     auto user = requireUser(req, callback);
-    if (!user || blockPasswordChangeRequired(*user, callback))
+    if (!user)
     {
         return;
     }
@@ -274,7 +261,7 @@ void AdminController::updateUserRoles(
     long long userId)
 {
     auto user = requireUser(req, callback);
-    if (!user || blockPasswordChangeRequired(*user, callback))
+    if (!user)
     {
         return;
     }
@@ -289,7 +276,7 @@ void AdminController::updateUserBan(
     long long userId)
 {
     auto user = requireUser(req, callback);
-    if (!user || blockPasswordChangeRequired(*user, callback))
+    if (!user)
     {
         return;
     }